Skip to content

Comments

feat: schedule GalileoV2 on Scroll Sepolia#1260

Merged
Thegaram merged 3 commits intodevelopfrom
feat-sepolia-schedule-galileo-v2
Nov 30, 2025
Merged

feat: schedule GalileoV2 on Scroll Sepolia#1260
Thegaram merged 3 commits intodevelopfrom
feat-sepolia-schedule-galileo-v2

Conversation

@Thegaram
Copy link

@Thegaram Thegaram commented Nov 27, 2025 •
edited by coderabbitai bot
Loading

1. Purpose or design rationale of this PR

Embed GalileoV2 timestamp for Scroll Sepolia.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Version updated to patch 18
    • ScrollSepolia chain configuration updated with new timestamp parameter for network alignment

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025 •
edited
Loading

Walkthrough

The pull request updates the ScrollSepolia chain configuration to activate the GalileoV2 fork at timestamp 1764831600 and increments the patch version from 17 to 18 in the version constants.

Changes

Cohort / File(s) Summary
Configuration Update
params/config.go		 Sets GalileoV2Time to newUint64(1764831600) in ScrollSepoliaChainConfig, replacing nil with a concrete fork activation timestamp
Version Bump
params/version.go		 Increments VersionPatch constant from 17 to 18

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These are straightforward value updates to configuration and versioning constants with no logic modifications or complex interactions.

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • roynalnaruto
  • georgehao

Poem

🐰 A timestamp thumps, a version hops,
ScrollSepolia's Galileo never stops,
From nil to time, the fork takes flight,
Patch eighteen shines forever bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: schedule GalileoV2 on Scroll Sepolia' clearly and concisely describes the main change—scheduling GalileoV2 on Scroll Sepolia testnet, which aligns with the changes made to ScrollSepoliaChainConfig and version bump.
Description check ✅ Passed The description covers all required template sections: states the purpose (Embed GalileoV2 timestamp for Scroll Sepolia), confirms PR title follows conventional commits (feat), confirms version.go was updated, and marks as not a breaking change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-sepolia-schedule-galileo-v2
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8629f08 and ae189f5.

📒 Files selected for processing (2)
  • params/config.go (1 hunks)
  • params/version.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
params/config.go (1)

331-337: GalileoV2 fork time wiring for Scroll Sepolia looks consistent

GalileoV2Time is now set to newUint64(1764831600), which is strictly after GalileoTime (1764054000) and all earlier fork times (Euclid*, Feynman) on Scroll Sepolia. This preserves the expected chronological ordering and only affects the ScrollSepolia chain config, leaving mainnet and other networks unchanged.

params/version.go (1)

24-29: Patch version bump aligns with the new fork scheduling change

Incrementing VersionPatch from 17 to 18 is appropriate for introducing the GalileoV2 scheduling on Scroll Sepolia, and all version helper functions continue to derive their strings from these constants without further changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Thegaram Thegaram marked this pull request as ready for review November 30, 2025 19:55
@Thegaram Thegaram merged commit 2986a6c into develop Nov 30, 2025
21 checks passed
@Thegaram Thegaram deleted the feat-sepolia-schedule-galileo-v2 branch November 30, 2025 20:07
@Thegaram Thegaram mentioned this pull request Nov 30, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Thegaram